Make RPC port number dependent on chain config #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheQuantumPhysicist
requested review from
muursh,
erubboli,
iljakuklic and
azarovh
as code owners
iljakuklic
approved these changes
Oct 20, 2023
muursh
approved these changes
Oct 20, 2023
OBorce
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1081
Besides that, I removed all websocket stuff because it didn't prove useful. It was originally added for the wallet and block production, but it seems that we don't need it.
IMPORTANT NOTE
After this is merged, the default RPC port for testnet will become 13030. This was a mistake that is now corrected. The port 3030 is reserved for mainnet, in parity with p2p's port 3031.