Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End-to-end encryption for staking key passing to block production #1288

Merged
merged 8 commits into from
Oct 20, 2023
Merged

End-to-end encryption for staking key passing to block production #1288

merged 8 commits into from
Oct 20, 2023

Conversation

TheQuantumPhysicist
Copy link
Collaborator

Closes #801

iljakuklic
iljakuklic approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@iljakuklic iljakuklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Although I cannot say I've fully scrutinised all the subtleties of the crypto stuff.

crypto/src/ephemeral_e2e/mod.rs Outdated Show resolved Hide resolved
@TheQuantumPhysicist TheQuantumPhysicist merged commit 6518524 into master Oct 20, 2023
31 checks passed
@TheQuantumPhysicist TheQuantumPhysicist deleted the feat/e2e-encryption branch October 20, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iljakuklic iljakuklic iljakuklic approved these changes

@muursh muursh muursh approved these changes

@OBorce OBorce OBorce approved these changes

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wallet handing staking key to block production should be end-to-end encrypted
4 participants
@TheQuantumPhysicist @iljakuklic @muursh @OBorce