Clean up P2pConfig #1295
Merged
Clean up P2pConfig #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
TheQuantumPhysicist
approved these changes
Oct 24, 2023
ImplOfAnImpl
force-pushed
the
make_connection_count_modifiable_in_tests
branch
from
1e1a3ca
to
f6e3ade
Compare
ImplOfAnImpl
force-pushed
the
cleanup_p2p_config
branch
from
2b31629
to
fe1b628
Compare
Base automatically changed from
make_connection_count_modifiable_in_tests
to
master
October 24, 2023 20:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
max_inbound_connectionsfield was moved toConnectionCountLimitsfor consistency.Protocol-related settings in
P2pConfigwere moved to a separate structProtocolConfig, so that they can be kept close together. With this, I want to close 1201. Note that initially I intended to do a bigger refactoring, e.g. I wanted to make settings likemsg_max_locator_count, which are not modified even in tests, constants. Now I think it won't be a good idea, because we may still want to modify them in tests in the future. Just keeping protocol settings in one place should be enough.