Fix some p2p issues #1306
Merged
Fix some p2p issues #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
requested review from
muursh,
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
6 tasks
ImplOfAnImpl
force-pushed
the
p2p_v2_issues
branch
2 times, most recently
from
9c7b58d
to
ce50a48
Compare
ImplOfAnImpl
force-pushed
the
p2p_v2_issues
branch
from
ce50a48
to
3d3b1d9
Compare
…blocks_are_being_sent
…e_blocks_are_being_sent back to 100
…blocks_are_being_sent; use explicit delay.
…blocks are requested out of order
ImplOfAnImpl
commented
Oct 31, 2023
ImplOfAnImpl
commented
Oct 31, 2023
Fixes in p2p related to blocks order
…ling_test Attempt to fix spuriously failing test "dont_make_announcements_while_blocks_are_being_sent". Also, PR #1316 was merged into this branch.
TheQuantumPhysicist
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following was done for both v1 and v2:
Fix potential header flooding by a malicious peer.
The node no longer allows new block headers to connect to
pending_headersonly.Conversely, when sending new headers, v2 node no longer takes
best_sent_block_headerinto account (and v1 didn't do this anyway).Nodes no longer send block announcements if
outgoing.blocks_queueis non-empty (because the peer will send a header request anyway when it's done downloading the blocks).The check for a duplicate block request was only working for already downloaded blocks, but not for those which are inside
outgoing.blocks_queue. I've added an additional check.I renamed the flag
send_tip_updatestohave_sent_all_headers, because it's exactly what it means.P.S. The fix for the failing test is in the separate PR #1309
Edit: PRs #1309 and #1316 were also merged into this one