Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2p: minor cleanup #1325

Merged
merged 1 commit into from
Nov 1, 2023
Merged

P2p: minor cleanup #1325

merged 1 commit into from
Nov 1, 2023

Conversation

ImplOfAnImpl
Copy link
Contributor

Here I add some comments and TODOs that we've discussed with Sam recently.

Also, request_blocks now overwrites incoming.requested_blocks instead of appending to it.

@ImplOfAnImpl ImplOfAnImpl marked this pull request as draft November 1, 2023 13:47
@ImplOfAnImpl ImplOfAnImpl marked this pull request as ready for review November 1, 2023 13:55
@TheQuantumPhysicist TheQuantumPhysicist merged commit ecf958b into master Nov 1, 2023
31 checks passed
@TheQuantumPhysicist TheQuantumPhysicist deleted the p2p_minor_cleanup branch November 1, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheQuantumPhysicist TheQuantumPhysicist TheQuantumPhysicist approved these changes

@muursh muursh Awaiting requested review from muursh

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@iljakuklic iljakuklic Awaiting requested review from iljakuklic

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImplOfAnImpl @TheQuantumPhysicist