-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for cold wallet #1497
Conversation
OBorce
commented
Jan 24, 2024
- add command line argument --cold-wallet to start the wallet without a node connection, with support of a subset of the commands
async fn get_block(&self, _block_id: Id<Block>) -> Result<Option<Block>, Self::Error> { | ||
Err(ColdWalletRpcError::NotAvailable) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this would be a compilation time error, where ColdWalletClient
does NOT implement NodeInterface
at all.
In the NodeController<N>
, only the methods that require communication with node would require the N: NodeInterface
constraint. Methods that do not need to communicate with the node leave N
unconstrained.
It is probably not a good time to do it now but please file an issue.