Add support for cold wallet #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OBorce
commented
Jan 24, 2024
OBorce
commented
- add command line argument --cold-wallet to start the wallet without a node connection, with support of a subset of the commands
OBorce
requested review from
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
TheQuantumPhysicist
approved these changes
Jan 25, 2024
iljakuklic
approved these changes
Jan 25, 2024
Comment on lines
+57
to
+59
| async fn get_block(&self, _block_id: Id<Block>) -> Result<Option<Block>, Self::Error> { | ||
| Err(ColdWalletRpcError::NotAvailable) | ||
| } |
There was a problem hiding this comment.
Ideally this would be a compilation time error, where ColdWalletClient does NOT implement NodeInterface at all.
In the NodeController<N>, only the methods that require communication with node would require the N: NodeInterface constraint. Methods that do not need to communicate with the node leave N unconstrained.
It is probably not a good time to do it now but please file an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.