mempool: Split into more well-defined components #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iljakuklic
requested review from
OBorce,
TheQuantumPhysicist,
ImplOfAnImpl and
azarovh
iljakuklic
force-pushed
the
mempool-split
branch
2 times, most recently
from
1312cba
to
de7d0c9
Compare
TheQuantumPhysicist
approved these changes
May 1, 2024
iljakuklic
force-pushed
the
mempool-split
branch
2 times, most recently
from
c7190c4
to
fa78af2
Compare
azarovh
approved these changes
May 3, 2024
This is a refactoring of mempool that splits it into multiple better isolated components with more well defined interfaces between them. * Top-level mempool acts as a coordinator and contains the other two as subcomponents. It also manages the emission of events and the contents of the orphan work queue. Upon reception of a transaction, it first attempts it to add to the transaction pool, and if it is rejected, it tries to add it to the orphan pool. If it's rejected by both, the transaction is rejected for good. * Transaction pool is the main mempool component. It holds transactions and keeps track of the utxo set defined by the transactions in the pool. It is also responsible for validating transactions upon insertion. * The orphan pool is a temporary holding space for transaction for which we do not know the complete set of parents. Some other minor changes are also included: * Remove `Arc` from around `MempoolConfig` (not needed) * Move some definitions to more logical places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring of mempool that splits it into multiple better isolated components with more well defined interfaces between them.
Some other minor changes are also included:
Arcfrom aroundMempoolConfig(not needed)