Call blockprod::find_timestamps_for_staking directly from wallet cli #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
requested review from
erubboli,
iljakuklic,
TheQuantumPhysicist and
azarovh
as code owners
ImplOfAnImpl
force-pushed
the
blockprod_timestamp_searcher
branch
from
d6fabf2
to
9cc49cf
Compare
ImplOfAnImpl
force-pushed
the
blockprod_timestamp_searcher_call_from_wallet_cli
branch
from
4692e08
to
e4040af
Compare
Comment on lines
+721
to
+738
| let mut rng = make_true_rng(); | ||
| let our_private_key = EndToEndPrivateKey::new_from_rng(&mut rng); | ||
| let our_public_key = our_private_key.public_key(); | ||
|
|
||
| let wallet = self.wallet().await?; | ||
|
|
||
| let callee_public_key = wallet.e2e_public_key().await?.take(); | ||
|
|
||
| let encrypted_input_data = wallet | ||
| .get_timestamp_search_input_data( | ||
| HexEncoded::new(our_public_key.clone()), | ||
| pool_id, | ||
| ) | ||
| .await?; | ||
| let shared_secret = our_private_key.shared_secret(&callee_public_key); | ||
| let secret_input_data = shared_secret | ||
| .decrypt_then_decode::<PoSTimestampSearchInputData>(&encrypted_input_data)?; | ||
|
|
There was a problem hiding this comment.
Can't we pack all this in one function or something, instead of doing it here inline?
ImplOfAnImpl
force-pushed
the
blockprod_timestamp_searcher
branch
from
9cc49cf
to
e480095
Compare
ImplOfAnImpl
force-pushed
the
blockprod_timestamp_searcher_call_from_wallet_cli
branch
from
e4040af
to
22bbbb1
Compare
I've added an issue for this - #1749 |
|
Closing this for now. It can be re-visited after #1749 is implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the problem from #1747 where the timestamp search RPC call from wallet-cli to wallet-rpc-daemon would timeout if the search takes a long time.
To solve the problem, the call to
blockprod::find_timestamps_for_stakingwas moved from the wallet controller to wallet-cli itself. Since the call needsPoSTimestampSearchInputData, I had to add theget_timestamp_search_input_datafunction to wallet RPC that returns the data. And since the data contains the private vrf key, I had to use e2e encryption for it.In the end, I'm not sure it's worth the added complexity, because the timeout problem only exists if wallet-cli connects to wallet-rpc-daemon.
Given that
FindTimestampsForStakingis a "niche" (and hidden) command, probably no one will ever use it in this scenario.