Introduce mintscript::SigntureOnlyChecker and use it in the wallet
#1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
force-pushed
the
feat/wallet_htlc_verify
branch
from
3b6817e
to
0dbd42e
Compare
ImplOfAnImpl
approved these changes
Jul 10, 2024
|
|
||
| use super::{InputCheckError, InputCheckErrorPayload, PerInputData}; | ||
|
|
||
| struct InputVerifyContextSignature<'a, T> { |
There was a problem hiding this comment.
This is a very confusing name
There was a problem hiding this comment.
this is just a name in line with others like InputVerifyContextTimelock
Comment on lines
+445
to
+454
| pub struct SignatureOnlyReward; | ||
|
|
||
| impl<C: SignatureInfoProvider> TranslateInput<C> for SignatureOnlyReward { | ||
| fn translate_input(_ctx: &C) -> Result<WitnessScript, TranslationError> { | ||
| // Not used anywhere. | ||
| // But it's important to outline that if needed the reward implementation must be different | ||
| // because staking/decommissioning destinations are not the same. | ||
| unimplemented!() | ||
| } | ||
| } |
There was a problem hiding this comment.
Why keep it if it's unused?
There was a problem hiding this comment.
I wanted to make it explicit for the future. So that noone tried to use implementation from transaction with reward (it might be a problem because both implement Transactable)
azarovh
force-pushed
the
feat/wallet_htlc_verify
branch
from
0dbd42e
to
a059999
Compare
OBorce
reviewed
Jul 11, 2024
azarovh
force-pushed
the
feat/wallet_htlc_verify
branch
from
9be918c
to
711ab1f
Compare
OBorce
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a problem that was introduced by HTLC change:
StandardInputSignature::raw_signaturecan encode additional layer withAuthorizedHashedTimelockContractSpend. Meaning thatcommon::StandardInputSignature::verify_signtaurecannot be called directly andInputWitnessmust be first evaluated with mintscript.mintscript::SignatureOnlyCheckerand public function intx_verifier::verify_tx_signaturePartiallySignedTransactionto common and remove sig verification logic from insidePartiallySIgnedTransaction