Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No start menu icons installed in win10 #166

Closed
zhuangh7 opened this issue Apr 22, 2019 · 19 comments
Closed

No start menu icons installed in win10 #166

zhuangh7 opened this issue Apr 22, 2019 · 19 comments

Comments

@zhuangh7
Copy link

I'm new user for wsltty, And this the first time I install wsltty 3.0.0. When installer say installed, but there only 4 files named "add to context menu", "add default to context menu", "configure WSL shortcuts" and "remove from context". And I find the only way I can start wsltty is open "add to context menu", and go to desktop and right click then finally choose start wsltty. But this is too complex and waste of time. How can I add a shortcut to my start menu or tast menu or anyway desktop? I think this should be created automaticly by the installer but it did not.

@zhuangh7
Copy link
Author

fine, I run "configure WSL shortcuts" in powershell and then it creat everything I need. Congratulations. But I believe it should run when installer installing or give me a feedback that something error instead of just installed.

@mintty
Copy link
Owner

mintty commented Apr 23, 2019

User preferences differ. Some users do not want shortcuts for all WSL distributions on their desktops. Many users particularly object against Explorer context menu entries installed automatically. So these are optional.
The installer installs shortcuts for all distributions that you have at the time of installing wsltty in your start menu. If you install another distro later, you may want to have a shortcut also. This is another use case for running these configuration scripts explicitly.
I will check how description can be improved to guide through these steps. Suggestions welcome.

@zhuangh7
Copy link
Author

thanks

@mintty
Copy link
Owner

mintty commented May 2, 2019

Reading again, apart from context menu entries, there should have been at least one desktop shortcut for the default WSL distribution, plus Start menu shorcuts for all distributions that you had deployed at the time of installing wsltty. Was that not the case?

@zhuangh7
Copy link
Author

zhuangh7 commented May 2, 2019

Thanks for your attentaion. But actually, the installer didn't create even one shortcut in my desktop. So at that moment I was confused.

@zhuangh7
Copy link
Author

zhuangh7 commented May 2, 2019

Im sure I already have an default WSL because after I install wsltty, I can open a wsltty window through right click on desktop and choose "start wsltty". Although, there is no any short on my desktop or start menu.

@mintty
Copy link
Owner

mintty commented May 2, 2019

It could be that your %USERPROFILE% is configured so that its Desktop is not a subfolder but a Windows shortcut (e.g. pointing to another disk). That might be raising problems, at least that's what I see on one system.
Uploading a patch for config-distros.sh.

mintty added a commit that referenced this issue May 2, 2019
@zhuangh7
Copy link
Author

zhuangh7 commented May 2, 2019

OK, this may help the latecomer, thx :>

@SimonPilkington
Copy link

Your current approach is also not foolproof. Many user profile folders can be moved individually to arbitrary locations. (Including roaming AppData. See here.) If this is the case, your shortcut will end up in an unused folder.

Consider using something like this instead.

@mintty
Copy link
Owner

mintty commented May 21, 2019

The environment variables (e.g. %APPDATA%) should always point to the proper place, even if relocated.
Which one does not work for you?

@SimonPilkington
Copy link

My AppData is not relocated, but my Desktop is on a different disk, so there is no way to reach it via the %APPDATA% variable.

@mintty
Copy link
Owner

mintty commented May 21, 2019

I had recently replaced "%USERPROFILE%\Desktop" (which turned out not to work in some situations) by "%APPDATA%\..\Desktop\", now this doesn't seem to work in other situations. Quite bothersome...
How about %Desktop%, actually, is that set properly for you?

@SimonPilkington
Copy link

%Desktop% is not a system variable unfortunately. The SO answer I linked above loads it from the registry.

@mintty
Copy link
Owner

mintty commented May 21, 2019

I think I saw %Desktop% on every Windows system so far, without extra configuration. Is it set properly on your system?

@mintty
Copy link
Owner

mintty commented May 21, 2019

Also, I see FOLDERID_Desktop in the same include file where FOLDERID_LocalAppData etc are defined.

@SimonPilkington
Copy link

I have access to three different Windows systems at the moment and none of them have %Desktop%. The FOLDERID_* variables are only defined in KnownFolders.h for use in code and are unrelated to environment variables. Only %AppData% and %LocalAppData% exist as environment variables to my knowledge.

@emberquill
Copy link

emberquill commented May 21, 2019

I don't have %DESKTOP% set on my system either (running Windows 10 1809 if that matters). I know you can query the registry for it. It's the Desktop value in:

HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\User Shell Folders

@mintty
Copy link
Owner

mintty commented May 22, 2019

Changed config script.

@mintty
Copy link
Owner

mintty commented May 28, 2019

Released 3.0.1.

@mintty mintty closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants