-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portable wsltty won't install to requested folder, breaking updates #359
Comments
With most installers, the question of whether you install to a given directory or into it is quite ambiguous. However, nothing has changed in the wsltty installer, and its final installation directory has always been called |
The issue is that when users choose a custom folder, that isn't where the installer installs to. It installs to a sub-folder of the chosen folder. It doesn't make sense preventing portable users from installing into a custom named folder. |
About update installation: yes, I can easily check whether the selected folder already contains a wsltty installation and use it in that case, rather than a new subdirectory. About proposing a proper subdirectory on initial install and allow to rename it: that would be a nice installer feature but the Windows folder browser function used does not offer such flexibility. Some software package provide that feature, many don't, so it does not help to claim the latter would not make sense, it's just how it is, by limitations of installer environments. About alternative installers, I commented before. Currently, wsltty uses only Windows on-board tools, which should also provide more trust in the package. If you demonstrate an easy packaging alternative with a better installer, I will consider it, but I can't spend much time into fiddling around that myself. |
Released 3.7.6.2. |
The installer for wsltty allows you to select an install folder, but installs it to a sub-directory of this folder.
For instance I tell the installer to install wsltty to:
But instead it installs it to:
This forces me to move all the files up one level, to the location I actually requested. This move then breaks all the prebuilt wsltty shortcuts. This move also prevents me from automatically installing updates for wsltty, because the installer then puts the updated files into a sub-folder of the old files.
At that point my only options for performing an update of wsltty are:
tar
archive from inside the newwsltty
folder, then extracting it over the top level of my old files. But that's too much work every update.I don't think the installer should demand a specific install directory name -- especially for portable apps -- which by their nature are installed to very random places like secondary hard drives or USB memory sticks.
If you simply want
wsltty
to be the default install folder, most wizard-style installers let you browse for a folder, and then append the default name like\wsltty\
to it. After browsing for a folder, the user can then manually erase the default sub-folder from the text before installing.Example wizard-style installer that allows the path to be edited after choosing an install folder:
In the wsltty installer, there is no way to edit the path after browsing for a folder, it immediately copies files to a sub-directory of the chosen folder.
There are FOSS wizard-style installers available that could avoid this issue, for example:
Inno Setup:
The text was updated successfully, but these errors were encountered: