Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2037 kat nmap normalizer #2038

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Fix/2037 kat nmap normalizer #2038

merged 11 commits into from
Nov 21, 2023

Conversation

originalsouth
Copy link
Contributor

Changes

This PR fixes issue #2037 by using the provided tunnel information of the protocol.

Issue link

Issue #2037

Closes #2037

Demo

image
Implemented test case passes.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@originalsouth originalsouth requested a review from a team as a code owner November 16, 2023 10:46
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can be improved even more

ammar92
ammar92 previously approved these changes Nov 20, 2023
@Donnype Donnype added bug Something isn't working boefjes Issues related to boefjes labels Nov 20, 2023
@underdarknl underdarknl merged commit aff2726 into main Nov 21, 2023
@underdarknl underdarknl deleted the fix/2037-kat_nmap-normalizer branch November 21, 2023 10:26
@originalsouth originalsouth restored the fix/2037-kat_nmap-normalizer branch July 29, 2024 14:07
@originalsouth originalsouth deleted the fix/2037-kat_nmap-normalizer branch July 29, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boefjes Issues related to boefjes bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Service name inference by port in kat_nmap normalizer
4 participants