fixed deprecations and updated requirements #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@craffel i think this one's good to go. The only question mark is whether you're okay with bumping the scipy version up to 1.0. (It's been almost a year at this point, I think it should be okay.) |
|
Looks good. Looks like there is one more deprecation warning in the CI, not sure if you want to fix here or not: |
|
Yeah, I noticed that. It's in the image comparison tests, and I think out of scope for what I want to do here. A proper fix for that would be included in #269 . |
|
Cool. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #276 by updating the display, segment, and doc build to reflect recent deprecations. Version requirements have been updated accordingly.
There should be no functionality change here.