Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to solve unit tests failing due to pytest #186

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

stevetorr
Copy link
Contributor

@stevetorr stevetorr commented Jun 12, 2020

Travis logs indicate that pytest is at too low a version (perhaps due to a change in some requirement by another library). I have fixed this by adding a minimum version to pytest in the requirements.txt.

@jonpvandermause
Copy link
Collaborator

Good catch, this seems to do the trick

@stevetorr
Copy link
Contributor Author

Thanks! I'll pull this once the travis passes.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #186 into master will increase coverage by 0.22%.
The diff coverage is 83.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
+ Coverage   58.62%   58.84%   +0.22%     
==========================================
  Files          35       35              
  Lines        7523     7545      +22     
==========================================
+ Hits         4410     4440      +30     
+ Misses       3113     3105       -8     
Impacted Files Coverage Δ
flare/gp.py 81.11% <83.92%> (+2.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7c057...0c3fcb6. Read the comment docs.

@stevetorr stevetorr merged commit 2e37071 into master Jun 12, 2020
@stevetorr stevetorr deleted the steven/patch/unit-test-failure branch June 12, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants