-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create dft_interface module to interface with multiple DFT software. #61
Conversation
…nce. use the function from predict.py now
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
+ Coverage 46.96% 53.2% +6.23%
=========================================
Files 37 43 +6
Lines 5636 6242 +606
=========================================
+ Hits 2647 3321 +674
+ Misses 2989 2921 -68
Continue to review full report at Codecov.
|
@anjohan Could you please help checking out how to install CP2K-6 in the Travis virtual machine properly? The Ubuntu16 LST repo only has CP2K-2... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flare/otf.py
Outdated
# force, var = self.gp.predict(chemenv, i + 1) | ||
# self.structure.forces[n][i] = float(force) | ||
# self.structure.stds[n][i] = np.sqrt(np.abs(var)) | ||
# self.local_energies[n] = self.gp.predict_local_energy(chemenv) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just delete these lines. Good riddance!
otf.run() | ||
os.system('mkdir test_outputs') | ||
os.system('mv h2_otf_qe_par* test_outputs') | ||
cleanup_espresso_run() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea to add tests of parallel OTF.
a new modeul "dft_interface" is set up in to allow a choice of software in OTF training.
closes #56 closes #14
This interface should make it much easier to have pymatgen and ase parser as mentioned in #19