🐛 Bugfix rescale key list introduced by the multilayer pull #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux-cpp-lisp
approved these changes
Feb 4, 2022
Comment on lines
+859
to
+871
| if validation: | ||
| scaled_out = out | ||
| _data_unscaled = data | ||
| for layer in self.rescale_layers: | ||
| # loss function always needs to be in normalized unit | ||
| scaled_out = layer.unscale(scaled_out, force_process=True) | ||
| _data_unscaled = layer.unscale(_data_unscaled, force_process=True) | ||
| loss, loss_contrib = self.loss(pred=scaled_out, ref=_data_unscaled) | ||
| else: | ||
| # If we are in training mode, we need to bring the prediction | ||
| # into real units | ||
| for layer in self.rescale_layers[::-1]: | ||
| out = layer.scale(out, force_process=True) |
There was a problem hiding this comment.
this looks correct--- have you tested it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Resolves: #???
How Has This Been Tested?
Types of changes
Checklist:
black.docs/options) has been updated with new or changed options.CHANGELOG.md.