Emit an error when the user supplies an empty suite name #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfe
force-pushed
the
forbid-empty-suite-name
branch
2 times, most recently
from
de6e6e5 to
88136a6
Compare
|
Will merge at the end of this week unless there are objections. |
craigfe
force-pushed
the
forbid-empty-suite-name
branch
from
88136a6 to
22c84f4
Compare
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Aug 26, 2020
…lwt (1.2.2) CHANGES: - Fail gracefully when the user supplies an empty suite name. (mirage/alcotest#265, @craigfe) - Fix compatibility with `fmt.0.8.8+dune` by adding a missing `fmt` dependency in `alcotest`'s dune file (mirage/alcotest#266, @NathanReb) - Only show "in progress" lines when writing to a TTY. (mirage/alcotest#267, @craigfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #264.
This emits an error message when the user supplies an empty test suite name, which previously raised an uncaught exception due to trying to create a corresponding symlink with an empty name. As discussed in the linked issue, it seems better to avoid empty suite names altogether.
Also adds a test for the similar case for empty test names, which isn't as problematic since we already append integers to these files on disk. In this case, I just chose to alter the filenames slightly to make sure that they don't start with a
..Introduces a common
user_errorfunction for handling such cases.