Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shorter random IDs for test runs #304

Merged
merged 1 commit into from
May 7, 2021

Conversation

craigfe
Copy link
Member

@craigfe craigfe commented May 6, 2021

Currently we use uuidm for generating test IDs. These seem a bit unnecessarily long to display / view when debugging: 8 alphanumeric characters is already enough for 3 trillion unique IDs, so I've gone with that.

@craigfe craigfe force-pushed the shorter-test-ids branch from b181a38 to f8d35be Compare May 6, 2021 22:15
Copy link

@Ngoguey42 Ngoguey42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craigfe craigfe merged commit eb04a75 into mirage:master May 7, 2021
craigfe added a commit to craigfe/opam-repository that referenced this pull request Oct 9, 2021
…and alcotest-lwt (1.5.0)

CHANGES:

- Make Alcotest compatible with `js_of_ocaml.3.11.0`. Users can depend on the
  new virtual `alcotest-js` Opam library to pick up the right `js_of_ocaml`
  version automatically. (mirage/alcotest#326 mirage/alcotest#328, @hhugo @smorimoto)

- Record exception backtraces during test suite runs by default. This behaviour
  can be disabled by passing `~record_backtrace:false` to `Alcotest.run`. (mirage/alcotest#317,
  @craigfe)

- Generate shorter unique identifiers for test runs (8-character alphanumeric,
  rather than a full 128-bit UUID). (mirage/alcotest#304, @craigfe)

- Change `Alcotest.{char,string}` pretty-printers to use OCaml syntax on
  assertion failures (i.e. wrap with quotes and escape control characters).
  (mirage/alcotest#318, @craigfe)

- Fix process for getting the width of attached terminals on MacOS.
  Previously, a terminal width of 80 columns was assumed. (mirage/alcotest#325, @craigfe)

- Fix parsing of test filter ranges to allow '-' separators (e.g. `test alpha
  1-4`), as advertised in the manpage. The previously-used '..' separator is
  also supported. (mirage/alcotest#312, @craigfe)

- Introduce an `Alcotest.V1` module that aliases the existing `Alcotest` API and
  provides a stability guarantee over major version changes. Similar versioned
  aliases also exist for the backends: `Alcotest_{async,lwt}.V1`. (mirage/alcotest#306,
  @craigfe)

- Change the `~filter` argument to `Alcotest.run` to be a predicate over tests.
  (mirage/alcotest#305, @craigfe)

- Renamed / removed some less frequently used modules used by the test backends:
  - `Alcotest.Unix` -> `Alcotest.Unix_platform`
  - `Alcotest_engine.{Cli,Core,Test}` -> `Alcotest_engine.V1.{Cli,Core,Test}`
  - `Alcotest.{Cli,Core}` are now gone. Use `Alcotest_engine.V1.{Cli,Core}.Make
    (Alcotest.Unix_platform)` instead.
  (mirage/alcotest#306 mirage/alcotest#309, @craigfe)

- Avoid exporting `list_tests` in the main test APIs (`Alcotest{,_lwt,_async}`).
  Use `Alcotest_engine` directly if you want this function. (mirage/alcotest#310, @craigfe)
craigfe added a commit to craigfe/opam-repository that referenced this pull request Oct 9, 2021
…and alcotest-lwt (1.5.0)

CHANGES:

- Make Alcotest compatible with `js_of_ocaml.3.11.0`. Users can depend on the
  new virtual `alcotest-js` Opam library to pick up the right `js_of_ocaml`
  version automatically. (mirage/alcotest#326 mirage/alcotest#328, @hhugo @smorimoto)

- Record exception backtraces during test suite runs by default. This behaviour
  can be disabled by passing `~record_backtrace:false` to `Alcotest.run`. (mirage/alcotest#317,
  @craigfe)

- Generate shorter unique identifiers for test runs (8-character alphanumeric,
  rather than a full 128-bit UUID). (mirage/alcotest#304, @craigfe)

- Change `Alcotest.{char,string}` pretty-printers to use OCaml syntax on
  assertion failures (i.e. wrap with quotes and escape control characters).
  (mirage/alcotest#318, @craigfe)

- Fix process for getting the width of attached terminals on MacOS.
  Previously, a terminal width of 80 columns was assumed. (mirage/alcotest#325, @craigfe)

- Fix parsing of test filter ranges to allow '-' separators (e.g. `test alpha
  1-4`), as advertised in the manpage. The previously-used '..' separator is
  also supported. (mirage/alcotest#312, @craigfe)

- Introduce an `Alcotest.V1` module that aliases the existing `Alcotest` API and
  provides a stability guarantee over major version changes. Similar versioned
  aliases also exist for the backends: `Alcotest_{async,lwt}.V1`. (mirage/alcotest#306,
  @craigfe)

- Change the `~filter` argument to `Alcotest.run` to be a predicate over tests.
  (mirage/alcotest#305, @craigfe)

- Renamed / removed some less frequently used modules used by the test backends:
  - `Alcotest.Unix` -> `Alcotest.Unix_platform`
  - `Alcotest_engine.{Cli,Core,Test}` -> `Alcotest_engine.V1.{Cli,Core,Test}`
  - `Alcotest.{Cli,Core}` are now gone. Use `Alcotest_engine.V1.{Cli,Core}.Make
    (Alcotest.Unix_platform)` instead.
  (mirage/alcotest#306 mirage/alcotest#309, @craigfe)

- Avoid exporting `list_tests` in the main test APIs (`Alcotest{,_lwt,_async}`).
  Use `Alcotest_engine` directly if you want this function. (mirage/alcotest#310, @craigfe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants