-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix charrua-client-lwt build #65
Conversation
This fixes the build. Note the CI isn't building this package at the moment. Signed-off-by: David Scott <dave@recoil.org>
.travis.yml
Outdated
@@ -9,7 +9,7 @@ env: | |||
- PACKAGE="charrua-core" | |||
- TESTS=true | |||
- PINS="charrua-client:. charrua-unix:." | |||
- DEPOPTS="charrua-client charrua-unix" | |||
- DEPOPTS="charrua-client charrua-client-lwt charrua-client-mirage charrua-unix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the build was not using depopts anymore (since the switch to jbuilder)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, maybe I need to make these PINS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably
Since this is a pure OCaml library I don't think we need to test on so many distros in travis -- if it builds in one place it should build everywhere I think. I might shrink the test matrix a bit. |
Signed-off-by: David Scott <dave@recoil.org>
I'd agree, but would prefer not to.
I've found bugs in dependencies (that are not pure).
Also, Anil merged chrrua unix into the repository. I dobt know the current
state, I believe it is not finished, that is not pure.
…On Tue 1. Aug 2017 at 12:44, David Scott ***@***.***> wrote:
Since this is a pure OCaml library I don't think we need to test on so
many distros in travis -- if it builds in one place it should build
everywhere I think. I might shrink the test matrix abit.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMdEF-Date0d7PJHuDzNuCXiYYvAjH4ks5sTwF2gaJpZM4OpiHA>
.
|
@haesbaert If you'd prefer to test more distros, I'll put them back. (I think I might have used a poor choice of word: by "pure" OCaml I meant "written entirely in OCaml with no C stubs" -- mostly cross-distro testing is useful for finding problems with missing C libraries and header files.) |
I think another dependency is missing:
|
The tcpip.unix package contains the checksum C stubs. Signed-off-by: David Scott <dave@recoil.org>
OK, CI seems to be fixed! |
This adds missing dependencies and hopefully re-enables CI for the
charrua-client-{lwt,mirage}
packages.