Fix charrua-client-lwt build

[djs55]

This adds missing dependencies and hopefully re-enables CI for the charrua-client-{lwt,mirage} packages.

[samoht]

I thought the build was not using depopts anymore (since the switch to jbuilder)?

[djs55]

ah, maybe I need to make these PINS?

[samoht]

probably

[djs55]

Since this is a pure OCaml library I don't think we need to test on so many distros in travis -- if it builds in one place it should build everywhere I think. I might shrink the test matrix a bit.

[haesbaert]

I'd agree, but would prefer not to. I've found bugs in dependencies (that are not pure). Also, Anil merged chrrua unix into the repository. I dobt know the current state, I believe it is not finished, that is not pure.

…

On Tue 1. Aug 2017 at 12:44, David Scott ***@***.***> wrote: Since this is a pure OCaml library I don't think we need to test on so many distros in travis -- if it builds in one place it should build everywhere I think. I might shrink the test matrix abit. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMdEF-Date0d7PJHuDzNuCXiYYvAjH4ks5sTwF2gaJpZM4OpiHA> .

[djs55]

@haesbaert If you'd prefer to test more distros, I'll put them back.

(I think I might have used a poor choice of word: by "pure" OCaml I meant "written entirely in OCaml with no C stubs" -- mostly cross-distro testing is useful for finding problems with missing C libraries and header files.)

[djs55]

I think another dependency is missing:

#=== ERROR while installing charrua-core.0.8 ==================================#
# opam-version         1.2.2
# os                   linux
# command              jbuilder runtest -p charrua-core -j 4
# path                 /home/opam/.opam/4.03.0/build/charrua-core.0.8
# compiler             4.03.0
# exit-code            1
# env-file             /home/opam/.opam/4.03.0/build/charrua-core.0.8/charrua-core-15681-1872ec.env
# stdout-file          /home/opam/.opam/4.03.0/build/charrua-core.0.8/charrua-core-15681-1872ec.out
# stderr-file          /home/opam/.opam/4.03.0/build/charrua-core.0.8/charrua-core-15681-1872ec.err
### stderr ###
# [...]
# /home/opam/.opam/4.03.0/lib/tcpip/tcpip.a(tcpip_checksum.o): In function `camlTcpip_checksum__fun_1205':
# :(.text+0xa): undefined reference to `caml_tcpip_ones_complement_checksum_list'
# /home/opam/.opam/4.03.0/lib/tcpip/tcpip.a(tcpip_checksum.o): In function `camlTcpip_checksum__fun_1207':
# :(.text+0x3a): undefined reference to `caml_tcpip_ones_complement_checksum'
# /home/opam/.opam/4.03.0/lib/tcpip/tcpip.a(tcpip_checksum.o): In function `camlTcpip_checksum__2':
# :(.data+0x58): undefined reference to `caml_tcpip_ones_complement_checksum_list'
# :(.data+0x60): undefined reference to `caml_tcpip_ones_complement_checksum'
# collect2: error: ld returned 1 exit status
# File "caml_startup", line 1:
# Error: Error during linking

[djs55]

OK, CI seems to be fixed!