-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use virtual_modules
in Dune 1.7
#59
Conversation
This allows use of the interface file separately from the implementations. We now provide separate implementations that use dune variants so that they can be found via a variants tag search: - `unix` (Unix or Windows) - `js` (JavaScript) - `xen` (Xen) This cleans up the utop toplevel support as well to work by default now. (@avsm, fixes mirage#50) Use implicit transitive dependencies, which will become the default in dune 2.0
- `xen` (Xen) | ||
|
||
This cleans up the utop toplevel support as well to work by | ||
default now. (@avsm, fixes #50) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
Should related to mirage/irmin#338 |
I still don't fully understand variants, but in the above list, what is happening with and what is the extensibility story - do all variants now need to end up in this thanks for working on this! and sorry for asking questions, but I could not discover where/whether they've been answered previously (please point me to a comment if this is the case) |
Do we really need variants when we could just rely on dune doing the correct cross-compilation of C bindings? e.g. in #60 I've simply removed the unix and xen subpackages and everything seems much cleaner/simpler :-) |
Closing in favour of #60 |
This allows use of the interface file separately from the implementations. We now provide separate implementations that use dune variants so that they can be found via a variants tag search:
unix
(Unix or Windows)js
(JavaScript)xen
(Xen)This cleans up the utop toplevel support as well to work by default now. (@avsm, fixes #50)
Also use implicit transitive dependencies, which will become the default in dune 2.0
I am noticing some local problems with opam installations though:
which is why I am marking this as a draft PR to work through the CI first.