-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the C layout of io-page according to MirageOS 3/4 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got an error on
But I can not reproduce it on my Ubuntu. Seems like a magic link error 😕 . |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Mar 22, 2021
CHANGES: * Use workspace flags (@TheLortex, mirage/io-page#60) * Use ocamlformat (@TheLortex, mirage/io-page#60) * **breaking changes** Remove io-page-xen and io-page-unix split (@samoht, mirage/io-page#60) * Update CI scripts (@samoht, mirage/io-page#60) * **breaking changes** Update the C layout of io-page according MirageOS 3/4 (@dinosaure, mirage/io-page#62) JS/C functions are renamed from `mirage_*` to `caml_mirage_iopage_*` * Add ocaml-freestanding and pkg-config as dependencies of `io-page` To be able to 'cross'-compile to Solo5
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Mar 22, 2021
CHANGES: * Use workspace flags (@TheLortex, mirage/io-page#60) * Use ocamlformat (@TheLortex, mirage/io-page#60) * **breaking changes** Remove io-page-xen and io-page-unix split (@samoht, mirage/io-page#60) * Update CI scripts (@samoht, mirage/io-page#60) * **breaking changes** Update the C layout of io-page according MirageOS 3/4 (@dinosaure, mirage/io-page#62) JS/C functions are renamed from `mirage_*` to `caml_mirage_iopage_*` * Add ocaml-freestanding and pkg-config as dependencies of `io-page` To be able to 'cross'-compile to Solo5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the plan of MirageOS 4 and the current status of
io-page
, this PR proposes to upgrade the project to the usual C layout to be compatible with MirageOS 3 and be ready for MirageOS 4.