Require OCaml 4.13 and remove local overrides #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aantron
added a commit
to aantron/dream
that referenced
this pull request
Aug 21, 2024
Dream no longer installs on lower OCaml versions, because mirage-crypto requires OCaml 4.13. See mirage/mirage-crypto#233 The reason for mirage-crypto requiring 4.13 seems to be minor convenience, and isn't justified in my opinion. However, Dream itself will likely require OCaml 5 in the medium term due to upgrading to multicore and effects, so it seems unnecessary to make an effort to restore 4.08 support at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somehow this seems to require on my laptop the(modes native)for all the test executables, as proposed in 764ccde (part of #227)just a dune issue, ocaml/dune#9979 -- let's not bother