-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: detect CPU architecture from C compiler #84
Conversation
this looks fine to me (travis failure is unrelated).. do you know of a CI setup to test cross-compilation (to ensure we don't break it in the future)? |
I can confirm that this patch resolves the issue. We have a private cross-compiling CI that targets ARM and uses some mirage packages, would be nice to make it available for open-source projects at some point. |
@hannesm My tooling uses esy for that, if you don't mind I can setup a CI to build for Android ARM64 |
@EduardoRFS if you can add a commit here that extends e.g. the GitHub actions (or travis) with such a job, that'd be great. Thanks a lot. |
bfa9dc9
to
b2b4214
Compare
@EduardoRFS thanks for your second commit, somehow the CI job fails to find ndk.zip - is it expected to work, should I restart the action, or do you have an adjustment to the runner for this? |
@hannesm I'm debugging it, it's something related to the shell used on the CI, I should finish it today |
@EduardoRFS great, thanks. if you rebase onto master, the travis CI should also turn green. |
* this allows to cross architecture cross-compiling
ab98a9a
to
0380f88
Compare
Ok now it should work for both DependenciesMost dependencies are extracted from opam and every commit
|
ef87c85
to
ab555a0
Compare
@hannesm sorry for all the CI noise. Zarith and GMP was a small problem and there was also an intermittent compile bug(solved) |
@EduardoRFS thanks for your work on this, one minor nit: could you squash the last 3 commits (CI-related) into one. then this is fine to be merged. I can also do a release to opam-repository if this eases your workflow. |
ab555a0
to
ff324b0
Compare
…mirage-crypto-rng-mirage (0.8.6) CHANGES: * Detect CPU architecture from C compiler, allowing cross-compiling to Android and iOS (mirage/mirage-crypto#84 by @EduardoRFC) * Upgrade to dune2, use a Makefile for building freestanding libraries, drop mirage-xen-posix support (solo5-based PVH exists now) mirage/mirage-crypto#86 by @hannesm
This allows to cross-compile from x86_64 -> ARM64.