revise Static_ipv4.connect signature: #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2018
- ip is a required keyword of type Ipaddr.V4.Prefix.t * Ipaddr.V4.t (no default value) - network is gone - ?gateway is Ipaddr.V4.t (used to be Ipaddr.V4.t option) --> connect does not fail anymore :)
hannesm
force-pushed
the
ipv4-signature
branch
from
13ef5c9
to
6e8adfb
Compare
|
I have a rebase on #420 which will be merged instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--> connect does not fail anymore :)
this PR and the others are staged in mirage-dev and lead to a successful build of mirage-skeleton
Mirage-dev build: https://travis-ci.org/mirage/mirage-dev/builds/464044337 (failing is only the genode target which never worked with travis)
Is anyone aware of other
Static_ipv4.connectusers?(split off from #380)