conduit-mirage: pass peer name to Tls.Config.client #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From my pov, this PR works perfectly well! Thanks! |
|
ok, CI is green. any comments @dinosaure @samoht |
|
LGTM |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Jul 4, 2022
…and conduit-async (5.1.1) CHANGES: * conduit-mirage: pass peer name to Tls.Config.client, fixes mirleft/ocaml-tls#474 reported by @palainp (mirage/ocaml-conduit#414 @hannesm) * conduit-async: update to jane street v0.15 (mirage/ocaml-conduit#414 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//cc @palainp this solves the issue you reported at mirleft/ocaml-tls#447 with the http-fetch unikernel.
Dear ocaml-conduit maintainers: what is the proper way to deal with
host(here being a string) does not conform being a[ `host ] Domain_name.t? In this PR, it is silently ignored -- I know not much about conduit and its semantics and usage.