Handle special dot and dotdot files #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricarkol
force-pushed
the
handle_dotdot
branch
2 times, most recently
from
6ccdf18
to
c59e1cf
Compare
|
@djs55 would you have a chance to review this so i can bundle it into the next release |
|
Yaay! thanks for the review |
|
this was approved half a year ago, and looks fine to me. I'll just merge it :) |
|
Thanks @hannesm |
samoht
added a commit
to samoht/opam-repository
that referenced
this pull request
Nov 21, 2019
CHANGES: - fix inconsistent sector size between block and fs (mirage/ocaml-fat#81, @ehirdoy) - adapt to newer MirageOS 3.7.1 interfaces (mirage/ocaml-fat#82, @hannesm) - Handle special dot and dotdot files (mirage/ocaml-fat#76, @ricarkol)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
dotanddotdotspecial files created with other FAT implementations when walking directory trees. Noticed this when trying to walk a disk image created bymkfs.fat + mount + mkdiron my linux box using the fat binary. More specifically, tried this test https://gist.github.com/ricarkol/f72687245e143bc04ba4814c6088d13e. That test creates 41 files in 3 levels of subdirs (countingdot's anddotdot's). Without this change, only 9 files are listed, and the fat bin raises an error: "fat: a directory in the path does not exist".Also, notice that this change doesn't complete the support for dot and dotdot special files. For example, two pending features are missing: create dot and dotdot special files on mkdir, and find files with paths like
/a/b/../c.