Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chores: update metadata and address deprecations #173

Merged
merged 7 commits into from
Jun 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ jobs:
- name: Install OCaml dependencies
run: opam install -t . --deps-only
- name: Build and test independently
run: opam install -t rpclib rpclib-js rpclib-html rpclib-lwt rpclib-async ppx_deriving_rpc
- name: Run Rpc Tests
run: opam exec -- dune runtest -p rpc
run: opam install -t rpclib rpclib-js rpclib-html rpclib-lwt rpclib-async
- name: Run Rpc and Ppx_deriving_rpc Tests
run: opam exec -- dune runtest -p ppx_deriving_rpc
- name: Build and run Examples
run: opam exec -- dune build @runexamples -p rpc
run: opam exec -- dune build @runexamples -p ppx_deriving_rpc
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## unreleased
* Removed deprecated rpc virutal package

## 9.0.0 (June 2022)
* Breaking: change Cmdlinergen to use non-deprecated types (psafont #172)

Expand Down
11 changes: 0 additions & 11 deletions docs/dune

This file was deleted.

6 changes: 3 additions & 3 deletions example/dune
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,22 @@
(alias runexamples)
(deps
(:e example.exe))
(package rpc)
(package ppx_deriving_rpc)
(action
(run %{e})))

(rule
(alias runexamples)
(deps
(:e example2.exe))
(package rpc)
(package ppx_deriving_rpc)
(action
(run %{e})))

(rule
(alias runexamples)
(deps
(:e example3_client.exe))
(package rpc)
(package ppx_deriving_rpc)
(action
(run %{e})))
4 changes: 2 additions & 2 deletions ppx_deriving_rpc.opam
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
opam-version: "2.0"
synopsis: "Ppx deriver for ocaml-rpc, a library to deal with RPCs in OCaml"
maintainer: "thomas@gazagnaire.org"
authors: "Thomas Gazagnaire, Jon Ludlam"
maintainer: "Marcello Seri"
authors: ["Thomas Gazagnaire" "Jon Ludlam"]
tags: ["org:mirage" "org:xapi-project"]
homepage: "https://github.com/mirage/ocaml-rpc"
doc: "https://mirage.github.io/ocaml-rpc/ppx_deriving_rpc"
Expand Down
37 changes: 0 additions & 37 deletions rpc.opam

This file was deleted.

4 changes: 2 additions & 2 deletions rpclib-async.opam
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
opam-version: "2.0"
synopsis: "A library to deal with RPCs in OCaml - Async interface"
maintainer: "thomas@gazagnaire.org"
authors: "Thomas Gazagnaire, Jon Ludlam"
maintainer: "Marcello Seri"
authors: ["Thomas Gazagnaire" "Jon Ludlam"]
tags: ["org:mirage" "org:xapi-project"]
homepage: "https://github.com/mirage/ocaml-rpc"
doc: "https://mirage.github.io/ocaml-rpc/rpclib-async"
Expand Down
4 changes: 2 additions & 2 deletions rpclib-html.opam
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
opam-version: "2.0"
synopsis:
"A library to deal with RPCs in OCaml - html documentation generator"
maintainer: "thomas@gazagnaire.org"
authors: "Thomas Gazagnaire, Jon Ludlam"
maintainer: "Marcello Seri"
authors: ["Thomas Gazagnaire" "Jon Ludlam"]
tags: ["org:mirage" "org:xapi-project"]
homepage: "https://github.com/mirage/ocaml-rpc"
doc: "https://mirage.github.io/ocaml-rpc/rpclib-html"
Expand Down
4 changes: 2 additions & 2 deletions rpclib-js.opam
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
opam-version: "2.0"
synopsis: "A library to deal with RPCs in OCaml - Bindings for js_of_ocaml"
maintainer: "thomas@gazagnaire.org"
authors: "Thomas Gazagnaire, Jon Ludlam"
maintainer: "Marcello Seri"
authors: ["Thomas Gazagnaire" "Jon Ludlam"]
tags: ["org:mirage" "org:xapi-project"]
homepage: "https://github.com/mirage/ocaml-rpc"
doc: "https://mirage.github.io/ocaml-rpc/rpclib-js"
Expand Down
4 changes: 2 additions & 2 deletions rpclib-lwt.opam
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
opam-version: "2.0"
synopsis: "A library to deal with RPCs in OCaml - Lwt interface"
maintainer: "thomas@gazagnaire.org"
authors: "Thomas Gazagnaire, Jon Ludlam"
maintainer: "Marcello Seri"
authors: ["Thomas Gazagnaire" "Jon Ludlam"]
tags: ["org:mirage" "org:xapi-project"]
homepage: "https://github.com/mirage/ocaml-rpc"
doc: "https://mirage.github.io/ocaml-rpc/rpclib-lwt"
Expand Down
4 changes: 2 additions & 2 deletions rpclib.opam
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
opam-version: "2.0"
synopsis: "A library to deal with RPCs in OCaml"
maintainer: "thomas@gazagnaire.org"
authors: "Thomas Gazagnaire, Jon Ludlam"
maintainer: "Marcello Seri"
authors: ["Thomas Gazagnaire" "Jon Ludlam"]
tags: ["org:mirage" "org:xapi-project"]
homepage: "https://github.com/mirage/ocaml-rpc"
doc: "https://mirage.github.io/ocaml-rpc/rpclib"
Expand Down
6 changes: 3 additions & 3 deletions src/js/rpc_client_js_helper.ml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
let keys obj =
let arr =
Js_of_ocaml.Js.Unsafe.meth_call
(Js_of_ocaml.Js.Unsafe.variable "Object")
(Js_of_ocaml.Js.Unsafe.pure_js_expr "Object")
"keys"
[| Js_of_ocaml.Js.Unsafe.inject obj |]
in
Expand All @@ -16,15 +16,15 @@ let keys obj =
let is_array obj =
let str =
Js_of_ocaml.Js.Unsafe.call
(Js_of_ocaml.Js.Unsafe.variable "Object.prototype.toString")
(Js_of_ocaml.Js.Unsafe.pure_js_expr "Object.prototype.toString")
obj
[||]
in
Js_of_ocaml.Js.to_string str = "[object Array]"


(* Magic to find out whether something is one of the Js_of_ocaml Javascript string types *)
let mlString_constr = Js_of_ocaml.Js.Unsafe.variable "MlString"
let mlString_constr = Js_of_ocaml.Js.Unsafe.pure_js_expr "MlString"
let is_string obj = Js_of_ocaml.Js.instanceof obj mlString_constr

(* Seems to work. I hope there's a better way of doing this! *)
Expand Down
2 changes: 1 addition & 1 deletion tests/rpc/dune
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

(rule
(alias runtest)
(package rpc)
(package ppx_deriving_rpc)
(deps
(:s suite.exe)
(source_tree .))
Expand Down