docs: factory - fix traits example #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code snippet changed in this PR is described with the following text `Here we define a withComments trait that creates 3 comments for a newly created post:` Creating a post requires having a factory on the path `mirage/factories/post.js` as opposed to `mirage/factories/user.js` Also to keep it consistent with the rest of the examples where posts have a property called `title`, as opposed to `name`, I went ahead and updated the `name` property on the factory to be `title`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code snippet changed in this PR is described with the following text
Here we define a withComments trait that creates 3 comments for a newly created post:Creating a post requires having a factory on the path
mirage/factories/post.jsas opposed tomirage/factories/user.jsAlso to keep it consistent with the rest of the examples where posts have a property called
title, as opposed toname, I went ahead and updated thenameproperty on the factory to betitle.