Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ember-auto-import and webpack to Ember v4 scenarios #2253

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Add ember-auto-import and webpack to Ember v4 scenarios #2253

merged 1 commit into from
Dec 3, 2021

Conversation

SergeAstapov
Copy link
Collaborator

@SergeAstapov SergeAstapov commented Dec 3, 2021 •
edited
Loading

This does not fix CI but fixes following error:

To use these addons, your app needs ember-auto-import >= 2: ember-source

We'll need to update some other dependencies to make CI pass, but let's keep PRs focused and fixing one error at a time.

@SergeAstapov
Copy link
Collaborator Author

Note that ember-auto-import@2 upgrade is breaking change hence we'll do it later once we start working on v3 of this addon

@SergeAstapov SergeAstapov merged commit cc232dc into miragejs:master Dec 3, 2021
@SergeAstapov SergeAstapov deleted the bump-ember-auto-import-v4-scenarios branch December 3, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cah-brian-gantzler cah-brian-gantzler Awaiting requested review from cah-brian-gantzler

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SergeAstapov