Add TS declaration for setupMirage
#2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes! I'm 100% up for this as v2 is still fully supported and I think we'll support it for some time until v3 surpasses v2 |
SergeAstapov
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
import { setupMirage } from 'ember-cli-mirage/test-support';works as expected for TypeScript users. It also adds a smalltypes-testssuite to verify that they work as expected.@SergeAstapov if I were to open a second copy of this PR against the
v2branch, is there a chance you'd be willing to include it in a 2.x release as well, since 3.0 is still in alpha? 🙂