Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Node.js 12 #2393

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Drop support for Node.js 12 #2393

merged 1 commit into from
Apr 13, 2022

Conversation

SergeAstapov
Copy link
Collaborator

Node.js 14 is currently in Maintenance LTS mode and slated for End Of Life (EOL) on 2023-04-30 (end of this month).

@SergeAstapov SergeAstapov added the Breaking Pull requests that include breaking changes label Apr 13, 2022
@cah-brian-gantzler
Copy link
Collaborator

The title is misleading. I thought you were dropping Node 14, you meant dropping 12 in favor of 14 :)
Might want to update the title to make it clearer

@SergeAstapov SergeAstapov changed the title Drop support for Node.js 14 Drop support for Node.js 12 Apr 13, 2022
@cah-brian-gantzler
Copy link
Collaborator

cah-brian-gantzler commented Apr 13, 2022 •
edited
Loading

What about https://github.com/miragejs/ember-cli-mirage/blob/master/.github/workflows/deploy.yml#L14
While its in the Github actions only really, should prob be consistant

@SergeAstapov
Copy link
Collaborator Author

thanks for noticing @cah-briangantzler! Of course meant dropping support for 12.x

gears in my head were spinning around about "making 14 min supported version" but hands wring commit message about dropping support for 12

@SergeAstapov
Copy link
Collaborator Author

What about https://github.com/miragejs/ember-cli-mirage/blob/master/.github/workflows/deploy.yml#L14 While its in the Github actions only really, should prob be consistant

Good point! Just pushed an update to update all workflows

@SergeAstapov SergeAstapov merged commit 7fb6fa9 into master Apr 13, 2022
@SergeAstapov SergeAstapov deleted the drop-node-12 branch April 13, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cah-brian-gantzler cah-brian-gantzler cah-brian-gantzler approved these changes

Assignees
No one assigned
Labels
Breaking Pull requests that include breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeAstapov @cah-brian-gantzler