-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure into monorepo #2395
Conversation
21a3329
to
2f6f64f
Compare
What is the difference between This appears to keep the actual test still in dummy in the addon. Future restructure to to extract that to a |
technically none.
|
I may have misread the PR, so many files changed. It looked like the end result would have both, didnt notice it was just a rename, wouldnt have ask. will look some more |
The scripts like |
It seems this file https://github.com/miragejs/ember-cli-mirage/pull/2395/files#diff-f79b9ecbffd42f337bfa51417cd40e5a274ce039d5042b27cc64cebf1558a1a0 was a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there suppose to be an empty file at `packages/ember-cli-mirage/.github/workflows/ci.yml?
Other than that, looked, lotta file changes obviously. But seems correct for what i could see
it was already removed, thanks for noticing! |
No description provided.