Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in #2558 (comment), on Windows, my team member @Ajanth wasn't able to run the desired server even after I updated
ember-cli-mirage
tov3.0.1
(see #2559).We think the issue is related to
config/environment.js#L14
, due toprocess.env.PWD
and the hardcoded/
's.After replacing
process.env.PWD
withprocess.cwd()
and/
withpath.join()
, we checked that we can run the server on both Windows and Mac. On Mac, I saw the same value logged for (1), (2), and (3):Note, a StackOverflow answer suggests that
process.env.PWD
andprocess.cwd()
can have a different meaning (value) when the current directory is changed. I'm not sure if that difference would affectember-cli-mirage
.