Feature: Add basic Google Artifact Registry support

[patricklubach]

Pull Request

Description

This PR adds basic support for Artifact Registry as on the one hand I need the support and on the other GCR Cleaner supports Artifact Registry too.

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

How Has This Been Tested?

I created a new Google Cloud project, switched to examples/minimal, created a terraform.tfvars file, add all necessary values for required variables. Run terraform init, terraform plan -out=terraform.plan and terraform apply terraform.plan.
When deployment finishes I verify GCR Cleaner Cloud Run and Cloud Scheduler Trigger are there. Trigger Cloud Run triggers and check status of last run was successful.

Checklist:

• My PR title follows semantics prefix
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings
• I have run pre-commit hooks pre-commit run -a
• CI tests are passing

[anouarchattouna]

Could you please add the google-beta provider configuration to each example's versions.tf file ?

    google-beta = {
      source  = "hashicorp/google-beta"
      version = ">= 4.1.0"
    }

[patricklubach]

Could you please add the google-beta provider configuration to each example's versions.tf file ?

    google-beta = {
      source  = "hashicorp/google-beta"
      version = ">= 4.1.0"
    }

I added them. Please review :)

[anouarchattouna]

LGTM!
Could you just double-check the pre-commit run -a command

[patricklubach]

@anouarchattouna I double checked the pre-commit run -a command and all checks passed :)
@PascalBourdier @mirakl-admin @nhuray can someone of you review too?

[christidis]

@patricklubach / @anouarchattouna / @PascalBourdier

how is this supposed to work for a docker repository in Artifact Registry and set different rules per docker image?

In gar_repositories there is an option for project_id for region and repository name but there is no option for a docker image name. (like there is for example in gcr_repositories).

  gar_repositories = [
    {
      project_id = "foobar-123"
      region     = "europe-west1"
      name       = "myrepo"
      parameters = {
        grace      = "180h"
        keep       = 3
        tag_filter = "^alpha.+$"
      }
    }
  ]

Assumming there are 2 docker image names unser myrepo GAR eg nginx and python how am I supposed to apply different rulesets for each one? Am I losing something?

Also I think this clean_all reference here is incorrect https://github.com/mirakl/terraform-google-gcr-cleaner/blob/main/variables.tf#L140

Update: I have opened this issue #52