Feature: Basic support for Google Artifact Registry #35
Conversation
|
I have to run pre-commit and extend the README. I will add the additional variable shortly. |
|
Hello @anouarchattouna, @PascalBourdier and @mirakl-admin, do anyone of have time to have a look on this? Would highly appreciate if you catch time. |
* Implement dry_run to easily list images to delete * Add dry-run in filter (used for job name) * Update locals to remove dry_run condition when parameters is not set * Fix expression for dry_run for repositories
|
Hi @patricklubach, thank you for this PR. |
|
I am facing this error when testing the minimal example │ Error: Error retrieving IAM policy for artifactregistry repository "projects/my-test-project/locations/europe-west3/repositories/nginx": googleapi: Error 403: The caller does not have permission
│
│ with module.gcr_cleaner.google_artifact_registry_repository_iam_member.member["nginx"],
│ on ../../iam.tf line 42, in resource "google_artifact_registry_repository_iam_member" "member":
│ 42: resource "google_artifact_registry_repository_iam_member" "member" { |
|
I'll try to quickly resolve all your findings. Thank you very much for reviewing! |
* Enforcement of Community Standards * rework GitHub Actions * Update LICENSE
…dd minimal example
patricklubach
changed the title
patricklubach
changed the title
| @@ -0,0 +1,128 @@ | |||
| # Contributor Covenant Code of Conduct | |||
There was a problem hiding this comment.
IMO, this kind of file should not be added to your PR.
There was a problem hiding this comment.
TBH, I don't know why this is included. All I did, is rebased my branch with the current main branch. Normally this shouldn't be changed or am I wrong?
There was a problem hiding this comment.
Could you please rebase yours with the last upstream main branch?
There was a problem hiding this comment.
I did but seems to be no changes to this issue. What's weird, is when I am doing a git diff upstream/main locally, I cannot see that these files are changed.
…rm-google-gcr-cleaner into artifact_registry
I tested minimal example and it works for me. No permissions is truly a very generic issue. Is there some way I can help you? |
…rm-google-gcr-cleaner into artifact_registry
|
@anouarchattouna I created another PR #39 that do not have all these file changes and close this one. I think the reason for this was a bit messed up git history. Sorry for that inconvenience. |
Hello there,
as the current version of terraform-google-gcr-cleaner only supports Google Container Registry, I wanted to add basic support for Google Artifact Registry as the gcr-cleaner already supports it and I need this feature for myself. Please have a look on this.