The own_name field in epoch_data is a [`host] Domain_name.t as well. #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The peer_name field is configured by the client (emitting a SNI (Server Name Indication) extension in the ClientHello). The own_name is filled by the server from the ClientHello SNI. This extends mirleft#434.
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Aug 2, 2021
CHANGES: * Breaking: peer_name (in config and epoch data, also own_name) is now a [`host] Domain_name.t instead of a string. (mirleft/ocaml-tls#434 mirleft/ocaml-tls#438 @torinnd @hannesm) * Add a X509_async module (mirleft/ocaml-tls#435 @torinnd) * Client and server constructor log messages are on the debug level (mirleft/ocaml-tls#436 reported by @talex5, fix by @hannesm) * Adapt to cstruct 6.0.0 API (Cstruct.len is deprecated) mirleft/ocaml-tls#439 @hannesm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The peer_name field is configured by the client (emitting a SNI (Server Name
Indication) extension in the ClientHello). The own_name is filled by the server
from the ClientHello SNI.
This extends #434.
//cc @torinnd (FYI)