-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose async tls_handler #448
Conversation
that's a pretty huge diff for the description. any chance you could remove any code formatting changes from this PR? also, maybe @torinnd could take a look at the changes? |
I'd probably recommend collapsing the new test_server_low_level example into the test_server. They don't look different enough to me to justify persisting both. I also think I'd refactor the MLI as follows:
Notably this excludes any mention of the socket address from the type signature as that isn't relevant to the TLS upgrade being performed here. Callers would probably do something like |
Thanks for the review. Collapsing the test servers into one and the .mli refactor done. I believe all of the extraneous code formatting has been removed (mostly in the dune file). |
Thanks for your contribution. I squashed and merged, this will be part of the next release. |
CHANGES: * New package tls-eio (mirleft/ocaml-tls#451 @talex5) * Tls_async: expose tls_handler (mirleft/ocaml-tls#448 @mbacarella, reviewed by @torinnd)
I proprose this PR to expose the async tls_handler to users of the library. This is needed if you want to do your own Tcp service management, such as if you're plugging async tls support into other frameworks.