Update to Eio 0.12 #479
Merged
Update to Eio 0.12 #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, writing to a closed connection raised `End_of_file`, but that is misleading (it's normally used when reading from an input stream, not when writing). This error normally occurs when the other end shut down one side of the connection (which currently causes both directions to be shut down). `tls_lwt` raises `Invalid_argument` in this case, but it seems more useful to group this with other errors where the remote end closes the connection, so I used Eio's `Connection_reset` error here. This was previously confusing the `copy` operation, which assumed there was no more data to copy rather than that the write had failed, and so didn't report an error at all in this case. I also enabled logging in the fuzz tests by default (at warning level). As well as ensuring that warnings are displayed, this also makes it easy to switch to debug logging when needed.
Fixes some linter warnings in CI.
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Sep 24, 2023
CHANGES: * tls-eio: update to eio 0.12 (mirleft/ocaml-tls#479 @talex5)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Sep 24, 2023
CHANGES: * tls-eio: update to eio 0.12 (mirleft/ocaml-tls#479 @talex5)
|
Thanks for your PR. I cut a release of tls-eio at ocaml/opam-repository#24515 (since I suspect you'd like to use this rather sooner than later). Since the rest of tls* is not affected, I did not add these packages to the release (this should safe quite some CPU cycles for people not using tls-eio). Enjoy the release. |
|
That's great - thanks! |
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: * tls-eio: update to eio 0.12 (mirleft/ocaml-tls#479 @talex5)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note: this looks long, but most of the changes are to the fuzz tests)
The changes to tls-eio.ml are:
Tls_socket_closederror. Writing to a closed connection previously reported end-of-file, which isn't quite right.readtosingle_read,writetosingle_write, andcopy_fromtocopy, to match the Eio 0.12 API.copynow uses an Eio helper that just callssingle_write.This removes all uses of objects from
tls-eio.ml.