Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE by updating loash #10

Merged
merged 2 commits into from
Aug 20, 2018

Conversation

rzr
Copy link
Collaborator

@rzr rzr commented Aug 8, 2018

Once release maybe we can consider to drop this dep

https://engineering.upside.com/you-dont-need-lodash-3323ca2cfb4c

rzr added 2 commits August 8, 2018 16:12
Change-Id: Ia217d5d6412a44a37127522b963f35aca73d650e
Signed-off-by: Philippe Coval <p.coval@samsung.com>
Relate-to: https://nvd.nist.gov/vuln/detail/CVE-2018-3721
Change-Id: I020b66ddb049ec9614b4117c4554e995ed8a591e
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr
Copy link
Collaborator Author

rzr commented Aug 8, 2018

I can also bump version or just type:
npm version && npm publish

Relate-to: https://github.com/rzr/generic-sensors-lite/network/dependencies

rzr added a commit to rzr/generic-sensors-lite that referenced this pull request Aug 8, 2018
Bug: miroRucka/bh1750#10
Change-Id: If972763bf1c363c255461452cf5d3a2242473141
Signed-off-by: Philippe Coval <p.coval@samsung.com>
@rzr
Copy link
Collaborator Author

rzr commented Aug 20, 2018

Please review @miroRucka @jasonyork @psmInterview @pilotak

@miroRucka miroRucka merged commit f8d3da7 into miroRucka:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants