This repository has been archived by the owner on Jul 18, 2018. It is now read-only.
forked from ChromiumWebApps/chromium
-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implementation of ReadableStream pipeTo and pipeThrough
Implement the pipeTo() and pipeThrough() methods on the ReadableStream class. They are only enabled when V8 experimental extras are, eg. when the --enable-experimental-web-platform-features flag is used. The methods are not visible when running without flags. To achieve this, the methods are defined in ReadableStream.js but not added to the global object. ReadableStreamExperimentalPipeTo.js is executed at renderer startup time when the experimental flag is set and simply adds the two methods to the global ReadableStream object. This initial implementation is intentionally unoptimised. While it does use internal APIs it won't perform any better than a polyfill using the public APIs would. Additional optimisation work is expected after shipping. Also remove the failing expectations for many external/wpt/streams tests that use piping. serviceworker still have failing expectations due to using HTTP. When web-platform-tests/wpt@f36afea is rolled from upstream the failures will go away. The upstream version of the streams/piping/multiple-propagation.js test 'Piping from an errored readable stream to a closed writable stream' doesn't pass in Chromium . This is a known incompatibility with the reference implementation which will be resolved by whatwg/streams#634. This CL adds a modified version of the test in http/tests/streams/piping which verifies the behaviour of this implementation. I have filed http://crbug.com/684543 to track it. BUG=668951 Review-Url: https://codereview.chromium.org/2561443004 Cr-Commit-Position: refs/heads/master@{#446358}
- Loading branch information
Showing
46 changed files
with
510 additions
and
669 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
...Tests/external/wpt/streams/piping/close-propagation-backward.dedicatedworker-expected.txt
This file was deleted.
Oops, something went wrong.
19 changes: 0 additions & 19 deletions
19
...Kit/LayoutTests/external/wpt/streams/piping/close-propagation-backward.https-expected.txt
This file was deleted.
Oops, something went wrong.
19 changes: 0 additions & 19 deletions
19
...outTests/external/wpt/streams/piping/close-propagation-backward.sharedworker-expected.txt
This file was deleted.
Oops, something went wrong.
29 changes: 0 additions & 29 deletions
29
...tTests/external/wpt/streams/piping/close-propagation-forward.dedicatedworker-expected.txt
This file was deleted.
Oops, something went wrong.
29 changes: 0 additions & 29 deletions
29
...bKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.https-expected.txt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.