Skip to content

Commit

Permalink
make tests compatible with Node.js 12 (#3304)
Browse files Browse the repository at this point in the history
In Node.js 12, the formatting of console arguments will change slightly.
Previously, a string other than the first argument was formatted using
single quotes if the first argument was non-string. Now, quotes are
never added regardless of position of a string argument.

To make test compatible in all Node.js versions, I work around by
ensuring the first argument to console.log is a string which prevents
the quotes from being added on older versions of Node.js.

Ref: nodejs/node#23162
  • Loading branch information
silverwind authored and alexlamsl committed Mar 12, 2019
1 parent 008c236 commit 9aae4f2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
12 changes: 6 additions & 6 deletions test/compress/evaluate.js
Original file line number Diff line number Diff line change
Expand Up @@ -1245,12 +1245,12 @@ self_comparison_1: {
}
input: {
var o = { n: NaN };
console.log(o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n, typeof o.n);
console.log(typeof o.n, o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n);
}
expect: {
console.log(false, false, true, true, "number");
console.log("number", false, false, true, true);
}
expect_stdout: "false false true true 'number'"
expect_stdout: "number false false true true"
}

self_comparison_2: {
Expand All @@ -1265,12 +1265,12 @@ self_comparison_2: {
}
input: {
var o = { n: NaN };
console.log(o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n, typeof o.n);
console.log(typeof o.n, o.n == o.n, o.n === o.n, o.n != o.n, o.n !== o.n);
}
expect: {
console.log(false, false, true, true, "number");
console.log("number", false, false, true, true);
}
expect_stdout: "false false true true 'number'"
expect_stdout: "number false false true true"
}

issue_2535_1: {
Expand Down
6 changes: 3 additions & 3 deletions test/compress/reduce_vars.js
Original file line number Diff line number Diff line change
Expand Up @@ -2740,18 +2740,18 @@ issue_1814_2: {
!function() {
var b = a + 1;
!function(a) {
console.log(a++, b);
console.log(b, a++);
}(0);
}();
}
expect: {
!function() {
!function(a) {
console.log(a++, "321");
console.log("321", a++);
}(0);
}();
}
expect_stdout: "0 '321'"
expect_stdout: "321 0"
}

try_abort: {
Expand Down

0 comments on commit 9aae4f2

Please sign in to comment.