Overlapping names between nested closures

[katyo]

I use UglifyJS a long time and I never had a similar problems.

Because the reproducing of this bug isn't trivial I created a gist located here https://gist.github.com/katyo/bd5a8811d63d77efeead

Gist

The source of function:

function replace(regex, options) {
  regex = regex.source;
  options = options || '';

  return function self(name, val) {
    if (!name) {
      return new RegExp(regex, options);
    }
    val = val.source || val;
    regex = regex.replace(name, val);
    return self;
  };
}

The result of uglification:

function e(e,t){e=e.source;t=t||"";return function n(r,n){if(!r){return new RegExp(e,t)}n=n.source||n;e=e.replace(r,n);return n}}

Human-readable version:

function e(e,t){
  e=e.source;
  t=t||"";
  return function n(r,n){
    if(!r){
      return new RegExp(e,t)
    }
    n=n.source||n;
    e=e.replace(r,n);
    return n
  }
}

Overlapping between function name self and variable name val (both named with n in result).

[mishoo]

Confirmed. Seems to happen only when sort is passed to the mangler. Just remove that flag for now, until we manage to fix. (if we even fix; I'm in favor of dropping that option completely).

[katyo]

Ok. Thanks.

[IngwiePhoenix]

Same for #990 - in fact, same function... x)

[kzc]

@rvanvelzen I think this original Issue can be closed by #991 as well.

[rvanvelzen]

@kzc absolutely right, thanks