Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore mangle sort option #991

Merged
merged 1 commit into from
Feb 28, 2016
Merged

Ignore mangle sort option #991

merged 1 commit into from
Feb 28, 2016

Conversation

kzc
Copy link
Contributor

@kzc kzc commented Feb 27, 2016

Ignore mangle sort option due to erroneous code generation: #877, duplicate #990.

Mangle sort option still retained but ignored for backwards compatibility.

@rvanvelzen
Copy link
Collaborator

I think this bug can't happen when sort is disabled, right? (Either the name is dropped, or it isn't shadowed)

@rvanvelzen rvanvelzen merged commit 102d1b9 into mishoo:master Feb 28, 2016
@kzc
Copy link
Contributor Author

kzc commented Feb 28, 2016

I'm not familiar with the mangler algorithm, but if sort is disabled, no one has complained of a similar bug.

Side note, when an invalid compress option is specified uglify will complain:

uglifyjs -c djfdjfh
`djfdjfh` is not a supported option

But it doesn't appear to complain for an invalid mangle option, so perhaps sort can be removed from _default_mangler_options altogether. I left the sort flag itself in the mangle options to be on the safe side in case it might impact downstream tools.

@kzc kzc mentioned this pull request Jul 8, 2017
@kzc kzc deleted the nosort branch November 21, 2018 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants