benchmark gzipped output #2220
Merged
benchmark gzipped output #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzc
reviewed
Jul 8, 2017
| @@ -65,6 +68,11 @@ urls.forEach(function(url) { | |||
| results[url].sha1 = data.toString("hex"); | |||
| done(); | |||
| }); | |||
| uglifyjs.stdout.pipe(zlib.createGzip({ | |||
| level: zlib.Z_BEST_COMPRESSION | |||
There was a problem hiding this comment.
Don't web servers generally use default gzip compression?
There was a problem hiding this comment.
FWIW, I used default gzip sizes for the benchmarks in the README.
There was a problem hiding this comment.
Don't web servers generally use default gzip compression?
For dynamic content, probably.
Static content are not compressed on the fly, so they tend to spend more effort in squeezing bigger savings.
In fact, there is zopfli which is crazy slow but produce gzip-compatible output - though I don't think there is widespread adoption of that one.
There was a problem hiding this comment.
Thanks. Good to know. Hadn't heard of zopfli.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2219 (comment)