-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divergent method signature for "count". Will Paginate does not work with Rails 4.1.2rc1. #382
Comments
prathamesh-sonpatki
added a commit
to codetriage/CodeTriage
that referenced
this issue
Jun 10, 2014
prathamesh-sonpatki
added a commit
to codetriage/CodeTriage
that referenced
this issue
Jun 14, 2014
Thanks ❤️ |
prathamesh-sonpatki
added a commit
to codetriage/CodeTriage
that referenced
this issue
Jun 27, 2014
mislav
added a commit
that referenced
this issue
Jun 28, 2014
prathamesh-sonpatki
added a commit
to codetriage/CodeTriage
that referenced
this issue
Jul 10, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We're using will_paginate on codetriage/codetriage and recently tried upgrading to Rails 4.1.2.rc1. While doing so we found there is an issue in the will_paginate method
page_entries_info
.page_entries_info
callscollection.size
. Thesize
method has been monkey patched but callssuper
which is defined in activerecord. The built insize
method was changed in this commit: rails/rails@afd4d82So that
count
is called with an argument:all
. Unfortunatelycount
is also overwritten by will_paginate and it does not have the same method signature, so it fails.Here's the backtrace:
I found this while investigating rails/rails#15430, though the issues seem to be unrelated.
The text was updated successfully, but these errors were encountered: