Failing specs for total_entries in Rails 4.1

[nathany]

This is the case where count(:all) should be the solution.
https://github.com/mislav/will_paginate/blob/master/lib/will_paginate/active_record.rb#L79

But that fails another test:

WillPaginate::ActiveRecord should not ignore :select parameter when it says DISTINCT
https://github.com/mislav/will_paginate/blob/master/spec/finders/active_record_spec.rb#L214

Using count(:all) doesn't work as desired if we actually want to keep the distinct select('DISTINCT salary'). And it appears not to work alongside select('salary').distinct either.

I'm not sure what the solution is.

[mislav]

Not sure what are you asking or what's going on :-]

[nathany]

@mislav Did you have a chance to look at the test and the failing spec in Travis CI?

I added line references to the description. Hope that helps.

some background: rails/rails#10710

[nathany]

So far will_paginate master has been working well with Rails 4.1 (our specs are passing). And we don't appear to need activerecord-deprecated_finders in our Gemfile either.

Still doing more testing.

[nathany]

Working well. If there were a will_paginate 3.0.6+, I'd be using it now. :-D