Skip to content

Commit

Permalink
bpo-46421: Fix unittest filename evaluation when called as a module (p…
Browse files Browse the repository at this point in the history
…ythonGH-30654)

(cherry picked from commit a0db11b)

Co-authored-by: Bader Zaidan <bader@zaidan.pw>
  • Loading branch information
miss-islington and BaderSZ authored Mar 18, 2022
1 parent ba76f90 commit 0b5f99a
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 1 deletion.
11 changes: 11 additions & 0 deletions Lib/test/test_cmd_line.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,17 @@ def test_run_module_bug1764407(self):
self.assertTrue(data.find(b'1 loop') != -1)
self.assertTrue(data.find(b'__main__.Timer') != -1)

def test_relativedir_bug46421(self):
# Test `python -m unittest` with a relative directory beginning with ./
# Note: We have to switch to the project's top module's directory, as per
# the python unittest wiki. We will switch back when we are done.
defaultwd = os.getcwd()
projectlibpath = os.path.dirname(__file__).removesuffix("test")
with os_helper.change_cwd(projectlibpath):
# Testing with and without ./
assert_python_ok('-m', 'unittest', "test/test_longexp.py")
assert_python_ok('-m', 'unittest', "./test/test_longexp.py")

def test_run_code(self):
# Test expected operation of the '-c' switch
# Switch needs an argument
Expand Down
2 changes: 1 addition & 1 deletion Lib/unittest/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def _convert_name(name):
name = rel_path
# on Windows both '\' and '/' are used as path
# separators. Better to replace both than rely on os.path.sep
return name[:-3].replace('\\', '.').replace('/', '.')
return os.path.normpath(name)[:-3].replace('\\', '.').replace('/', '.')
return name

def _convert_names(names):
Expand Down
1 change: 1 addition & 0 deletions Misc/ACKS
Original file line number Diff line number Diff line change
Expand Up @@ -1983,6 +1983,7 @@ Masazumi Yoshikawa
Arnaud Ysmal
Bernard Yue
Moshe Zadka
Bader Zaidan
Elias Zamaria
Milan Zamazal
Artur Zaprzala
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix a unittest issue where if the command was invoked as ``python -m
unittest`` and the filename(s) began with a dot (.), a ``ValueError`` is
returned.

0 comments on commit 0b5f99a

Please sign in to comment.