Sound player delay, animated image start frame stills #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanwinkle
force-pushed
the
sound-player-delay
branch
from
fcfc1ec to
bb9bdb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
delayoption for SoundPlayer from missionpinball/mpf#1541.This PR also adds some improved behavior to animated image playback. The
start_framesetting is applied to the image when playback begins—something that never occurs on images that don't play. This PR tweaks the behavior to always trigger play (thereby jumping to the correct frame) and then immediately stop animations that shouldn't play.The result of this change is that an image animation can be created to store multiple states of an image (e.g. a progress bar) and a specific frame can be displayed without animating it.