Fix bug in jump_to action by adjusting for sample frames #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcapen
reviewed
Jun 24, 2021
qcapen
reviewed
Jun 24, 2021
|
LGTM! |
Copy/pasted the utility function, _fix_sample_from_pos, from track_standard.pyx and included it in track_sound_loop.pyx. Updated logic in def jump_to_time_current_sound_loop_set(..) and other places in this file where sample frame adjustment is calculated to use this new utility function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy/pasted the utility function, _fix_sample_from_pos, from track_standard.pyx and included it in track_sound_loop.pyx.
Updated logic in def jump_to_time_current_sound_loop_set(..) and other places in
this file where sample frame adjustment is calculated to use this new
utility function.
Add a commented out line that linux users can use for the log file in audio_interface.pyx
Added assertions in test to verify jump_to action.