Merge pull request #1797 from missionpinball/service-mode-refactor-0.80

Service Mode Refactor for 0.80

mpf/core/bcp/bcp_interface.py

@@ -101,10 +101,10 @@ def remove_registered_trigger_event_for_client(self, client, event):
         if not self.machine.bcp.transport.get_transports_for_handler(event):
             self.machine.events.remove_handler_by_event(event=event, handler=self.bcp_trigger)
 
-    async def _bcp_receive_set_machine_var(self, client, name, value):
+    async def _bcp_receive_set_machine_var(self, client, name, value, persist=False):
         """Set machine var via bcp."""
         del client
-        self.machine.variables.set_machine_var(name, value)
+        self.machine.variables.set_machine_var(name, value, persist)
         # document variables injected by MC
         '''machine_var: mc_version
 
@@ -472,7 +472,7 @@ def _monitor_machine_vars_stop(self, client):
             self.machine.machine_var_monitor = False
 
     def _send_machine_settings(self, client, setting_type=None):
-        settings = [setting_type] if setting_type else ["standard", "feature", "game", "coin"]
+        settings = [setting_type] if setting_type else ["standard", "feature", "game", "coin", "hw_volume"]
         for s in settings:
             self.machine.bcp.transport.send_to_client(
                 client, bcp_command='settings',

mpf/core/config_processor.py

@@ -152,12 +152,12 @@ def _check_sections(self, config_spec, config, config_type, filename, ignore_unk
 
         deprecated_080 = ["sound_pools"]
         invalid_080 = ["playlists", "playlist_player", "slides", "sounds", "sound_loop_player",
-                          "sound_loop_sets", "sound_system", "track_player", "widgets"]
+                       "sound_loop_sets", "sound_system", "track_player", "widgets"]
         for k in config.keys():
             if k in config_spec:
                 if k in deprecated_080:
-                    self.log.warning("Config section '%s' is deprecated in MPF 0.80 and will be unsupported in future versions. "
-                                     "Please migrate this config to GMC.", k)
+                    self.log.warning("Config section '%s' is deprecated in MPF 0.80 and will be unsupported "
+                                     "in future versions. Please migrate this config to GMC.", k)
                 if config_type not in config_spec[k]['__valid_in__']:
                     raise ConfigFileError('Found a "{}:" section in config file {}, '
                                           'but that section is not valid in {} config '

mpf/core/config_validator.py

@@ -356,7 +356,7 @@ def _validate_type_subconfig(self, item, param, validation_failure_info):
         # The inclusion of sound_pools causes a nested ducking subconfig that
         # fails due to missing required properties. Check for an empty dict
         # as subconfig and ignore it.
-        if item is None or (item is Dict and not len(item)):
+        if item is None or (item is Dict and len(item) == 0):
             return {}
         try:
             attribute, base_spec_str = param.split(",", 1)

mpf/core/crash_reporter.py

@@ -176,7 +176,7 @@ def analyze_traceback(tb, inspection_level=None, limit=None):
 
 
 def _send_crash_report(report, reporting_url):
-    r = requests.post(reporting_url, json=report)
+    r = requests.post(reporting_url, json=report, timeout=60)
     if r.status_code != 200:
         print("Failed to send report. Got response code {}. Error: {}", r.status_code, r.content)
     else:

mpf/core/machine_vars.py

@@ -182,6 +182,9 @@ def set_machine_var(self, name: str, value: Any, persist=False) -> None:
         ----
             name: String name of the variable you're setting the value for.
             value: The value you're setting. This can be any Type.
+            persist: Whether to persist this machine var to disk. Only
+                applies to new/unconfigured vars; vars defined in the
+                machine_vars config will use their config setting.
         """
         if name not in self.machine_vars:
             self.configure_machine_var(name=name, persist=persist)